Unconfigured Ad

Collapse
X
 
  • Filter
  • Time
  • Show
Clear All
new posts
  • hv4
    Junior Member
    • Aug 2011
    • 4

    trimming bases

    Hi,

    When trimming reads I found Perl to be really slow for large files.

    I wrote this C program to trim at the left and right ends.

    Does this look OK to you?

    #include<stdio.h>

    void main(int argc, char *argv[])
    {
    FILE *fp_in, *fp_out;
    char buffer[1000];
    int count_lines;
    int left_cut;
    int right_cut;

    if (argc!=4)
    {
    printf("Need input and output files and cuts, here's the order:\n");
    printf("Input, output, left cut, right cut (reference from the left)\n");
    return;
    }

    fp_in = fopen(argv[1], "r");
    fp_out = fopen(argv[2], "w");

    sscanf(argv[3],"%d",&left_cut);
    sscanf(argv[4],"%d",&right_cut);

    //printf("\n%d, %d\n", left_cut, right_cut);

    count_lines = 0;

    while(!feof(fp_in))
    {
    fgets(buffer, 1000, fp_in);

    if ((count_lines%2)==0)
    {
    fputs(buffer,fp_out);
    }
    else
    {
    buffer[right_cut]=0;
    fputs(&buffer[left_cut],fp_out);
    fputc('\n',fp_out);
    }

    count_lines++;
    }


    fclose(fp_in);
    fflush(fp_out);
    fclose(fp_out);

    }
  • bioBob
    Member
    • Mar 2011
    • 72

    #2
    Don't forget to remove the mate if your trimming removes the whole read and you are looking at paired end data.

    Comment

    • westerman
      Rick Westerman
      • Jun 2008
      • 1104

      #3
      1) Assumes the arguments are what they are (e.g., file names)
      2) Assumes reads are less than 1000 bases
      3) Assumes reads are strictly header line followed by a single line of bases.
      4) Assumes reads are all the same length
      5) Assumes that the right cut position is not greater than the length of the reads.

      I'd put, up-front, the assumptions so that people are not bitten by them. I'd also do more error checking.

      Comment

      • hv4
        Junior Member
        • Aug 2011
        • 4

        #4
        Thank you for your feedback.

        @bioBob:

        The program does not remove any reads. Just trims them.

        You can use it with paired reads since the program does exactly the same thing
        for both reads.

        @westerman

        Your list is great. Indeed, the program is made to serve a narrow purpose.

        To your list I would also add that the right_cut position specified as a parameter must be +1 than the one intended.

        Comment

        • bioinfosm
          Senior Member
          • Jan 2008
          • 483

          #5
          how does this compare to cutadapt tool?
          --
          bioinfosm

          Comment

          Latest Articles

          Collapse

          • SEQadmin2
            Nine Things a Sample Prep Scientist Thinks About Before Sequencing
            by SEQadmin2


            I’m not a sequencing expert. I’m a purification scientist who uses NGS to evaluate workflows my group develops. With this perspective, we think about the sample first and the NGS workflow second. The sequencer is an exceptionally honest reporter, but it can only report on what you give it, so whether you get clean, interpretable data from an NGS workflow is largely determined before you begin.

            Here are nine questions we think about, in roughly the order they matter, before...
            06-18-2026, 07:11 AM
          • SEQadmin2
            From Collection to Sequencing: Why Sample Preparation and Preservation Define Sequencing Data
            by SEQadmin2


            Data variability is still an issue in sequencing technologies despite the advances in reproducibility and accuracy of these platforms. But the problem does not originate in the sequencing itself, but in the previous steps, before the sample reaches the sequencer.


            The first step is collection, followed by preservation and sample preparation for analysis. Most scientists overlook those steps, but not being careful might just be skewing the experiment’s results.
            ...
            06-02-2026, 10:05 AM

          ad_right_rmr

          Collapse

          News

          Collapse

          Topics Statistics Last Post
          Started by SEQadmin2, 06-17-2026, 06:09 AM
          0 responses
          38 views
          0 reactions
          Last Post SEQadmin2  
          Started by SEQadmin2, 06-09-2026, 11:58 AM
          0 responses
          101 views
          0 reactions
          Last Post SEQadmin2  
          Started by SEQadmin2, 06-05-2026, 10:09 AM
          0 responses
          123 views
          0 reactions
          Last Post SEQadmin2  
          Started by SEQadmin2, 06-04-2026, 08:59 AM
          0 responses
          114 views
          0 reactions
          Last Post SEQadmin2  
          Working...